hashicorp / hashicorp/consul

Early server errors can fail to log when the server is shutdown

Open
#3,420 0 comments 0 reactions 0 assignees View on GitHub
theme/operator-usability type/bug
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

From https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/consul-tool/EoGPwvesmT8/-GyPaCEeAAAJ it looks like the pattern of calling `s.Shutdown()` is preventing the errors from getting logged properly, making it hard to diagnose what's going on if things fail super early in `NewServer()`.

Contributor guide

Open the contributing guide

Research direction

Start by tracing NewServer and the s.Shutdown() path described in the issue, focusing on what happens when initialization fails very early. Confirm the failure mode with an early NewServer error and determine what logging behavior is expected during shutdown; done means those errors are reliably logged for diagnosis.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, observability
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.