hashicorp / hashicorp/consul

testutil: Should ensure `consul` executable is correct version or use embedded code

Open
#2,465 5 comments 0 reactions 0 assignees View on GitHub
theme/internal-cleanup type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
2d 6h
Merged PRs (30d)
43

Description

Client: `0.7.0`
Server: `0.7.0`

### Description of the Issue (and unexpected/desired result)

Products such as `consul-template` use `testutil` to spin up Consul servers. While developing a patch I was hitting unexpected issues in tests. The cause was a local `consul` binary being out of date. Note that `consul-template` includes the full `consul` repo as a vendor source.

### Reproduction steps

* Install `consul` binary 0.6.3 into the path
* Download `consul-template` and issue `make test`

Various failures are experienced.

Upgrade `consul` binary to 0.7.0 and issues are resolved.

### Suggestion

It would be nice if the test util did one of the following:

* validated the version of the Consul binary it uses to match the configured version
* validated the version of the Consul binary it uses to a supported version
* used the local Consul code to spin up the server
* At least indicated the mismatch

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.