hashicorp / hashicorp/consul

Please stop (unnecessarily) updating go version in go.mod

Open
#23,032 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

#### Feature Description

Please stop updating to the latest release if its unnecessary. This forces downstream users and end-users to have to use that toolchain. This seems unnecessary since the commit messages for the changes provide no reasoning as I'd expect if there was a need to upgrade. According to go.dev:

> A go directive indicates that a module was written assuming the semantics of a given version of Go. The version must be a valid [Go version](https://go.dev/doc/toolchain#version), such as 1.14, 1.21rc1, or 1.23.0.
>
> The go directive sets the minimum version of Go required to use this module. Before Go 1.21, the directive was advisory only; now it is a mandatory requirement: Go toolchains refuse to use modules declaring newer Go versions.

As far as I can see nothing is changing in the PRs that bump the go version so therefore the code base isn't changing to assume new semantics based on go version. Please stop the useless churn, this feels like it goes against the spirit of MVP of managing go deps.

Contributor guide

Open the contributing guide

Research direction

Start by inspecting go.mod and the prior pull requests that changed its Go version. Determine what process is making those updates and which version changes are actually required; done means unnecessary Go-version churn is avoided without removing required compatibility changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.