hashicorp / hashicorp/consul

Use the check state index when filtering for passing services

Open
#1,993 0 comments 0 reactions 0 assignees View on GitHub
theme/api type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

This is a super common operation, but we do the filtering up on the agent. We should change the RPC logic to push that filtering down to the servers, since we already maintain an index:

https://groups.google.com/d/msgid/consul-tool/CABJfL5jZrvwNp%2BXWg56OkJ26REz%2B%3Dc1ZV_U6yv%3D7Ep%2Bs3dX%2BEA%40mail.gmail.com?utm_medium=email&utm_source=footer

Contributor guide

Open the contributing guide

Research direction

Start by tracing the RPC logic that currently filters passing services on the agent, then locate the existing check state index on the servers. The work is done when matching services are filtered server-side through that index and the agent no longer performs the common filtering operation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, distributed-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.