hashicorp / hashicorp/consul

Add return code to dns debug log and dns metrics

Open
#19,826 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

Better DNS metrics and logs.

When managing large consul clusters seeing changes in request rates for things that don't exist is super helpful.
This is often times not a problem with the consul platform itself as healthchecks and requests resolution are workign as expected. Still this is often a broken healthcheck or changed client behavior. The service discovery system can help alert and track down these changes.

#### Feature Description

Add rcode to the consul debug log level dns information

Add rcode and query type tag information to the dns latency metrics, this can detect an increase in nxdomain requests or help narrow down performance issues related to a particular query pattern.

The logging is implemented here: https://github.com/hashicorp/consul/pull/19825

#### Use Case(s)

Service Discovery -- helps identify clients using the dns interface that are still calling services that are no longer deployed / healthy.

Contributor guide

Open the contributing guide

Research direction

Review the DNS debug logging and DNS latency metric paths, starting with the logging implementation referenced in PR #19825. Add return-code data to debug logs and both return-code and query-type tags to latency metrics, then verify that DNS request patterns such as NXDOMAIN responses are observable.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking, observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.