hashicorp / hashicorp/consul

acl: error when an unknown key exists in an hcl ACL policy

Open
#11,352 8 comments 0 reactions 0 assignees View on GitHub
theme/acls theme/operator-usability type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
2d 6h
Merged PRs (30d)
43

Description

Currently any unknown keys are ignored. So if a rule is misspelled the policy is still saved. The problem won't be noticed until the policy is assigned to a token, and someone tries to use the token.

I attempted to make this work with `hclv1` `unknownKeys`, but that doesn't quite work because the names of resources are reported as unknown keys. Nomad addresses this problem with something like this: https://github.com/hashicorp/nomad/blob/1bd132f/helper/funcs.go#L442

Fixing this may require upgrading to hclv2.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.