hashicorp / hashicorp/consul

checks: add support for delaying the first health check

Open
#10,864 1 comment 1 reaction 0 assignees View on GitHub
theme/health-checks type/enhancement
Dominant language
Go
Stars
30.1k
Forks
4.6k
Avg merge
1d 18h
Merged PRs (30d)
39

Description

See #10256 and hashicorp/nomad#9189 for more context

#### Feature Description

Copied from https://github.com/hashicorp/nomad/issues/9189

> [Consul] check option `success_before_passing` is not honored independently of the value it is configured to. As soon as the first check is successful the instance is marked as passing. Furthermore the first check delay doesn't seem to be guided by interval making it impossible to deterministically define a waiting period before marking a service as ready.

> The expected result would be that the instance is marked critical for interval * success_before_passing and only after marked as passing.

Making that change to `success_before_passing` would be a breaking change, but we can introduce a different field to delay the first health check and prevent it from going to passing.

#### Use Case(s)

See linked issue and PR.

Contributor guide

Open the contributing guide

Research direction

Begin by reading #10256 and hashicorp/nomad#9189, which provide the referenced context for the health-check behavior. The work is done when a new field can delay the first health check and keep the instance from passing until the intended interval and success conditions are met.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.