hashgraph / hashgraph/solo-weaver

Extend upgrade_monitor_test.go to cover frozen phase job execution

Open
#859 0 comments 0 reactions 0 assignees View on GitHub
New Feature Story
Dominant language
Go
Stars
3
Forks
0
Avg merge
3d 5h
Merged PRs (30d)
47

Description

**Epic:** #1080

Add test cases to `internal/daemon/consensus/upgrade_monitor_test.go`:
- Jobs dir present with one `(upgrade, frozen)` job → runs before upgrade scripts
- Jobs dir absent → upgrade scripts run normally (no-op)
- Abort failure → DaemonResult=Failed with `ReasonDaemonCustomJobFailed`
- Ignore failure → warning logged; upgrade scripts run
- Sequence order: 3 jobs at frozen phase run in ascending sequence

## Acceptance Criteria
- [ ] All scenarios covered with fake K8s client
- [ ] Tests are hermetic (no real cluster needed)
- [ ] Existing tests unaffected

Contributor guide

Open the contributing guide

Research direction

Start with internal/daemon/consensus/upgrade_monitor_test.go and its existing fake Kubernetes client setup. Add coverage for frozen-phase job ordering, absent jobs, abort failures, and ignore failures, then run the focused test file. Done means every listed scenario is hermetic and the existing tests remain unaffected.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.