hashgraph / hashgraph/pbj

Allow mapping of Timestamp to Instant

Open
#62 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
44
Forks
15
Avg merge
1d 15h
Merged PRs (30d)
12

Description

### Problem

In 100s of places thought the Hedera node we convert Timestamps to and from Instants. It would be nice to avoid all that effort, engineer time and at runtime.

### Solution

Add a special comment config in protobuf files to map a protobuf message like `Timestamp` that has two fields second and nanos to a `java.time.Instant`. If that feature is enabled then replace all references to the protobuf message that has the comment to use `Instant` instead. So if another message has a field of type `Timestamp` it will now be of type `Instant`.

### Alternatives

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.