harfbuzz / harfbuzz/harfrust

HarfRust should not panic on an invalid language

Open
#372 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
301
Forks
26
Avg merge
10h 11m
Merged PRs (30d)
43

Description

From Blink testing with HB-HR:

```
STDERR: [9524:11572:0529/031140.483:FATAL:third_party/harfbuzz/src/src/rust\shape.rs:188] panicked at ../../third_party/harfbuzz/src/src/rust\shape.rs:188:53:
STDERR: called `Result::unwrap()` on an `Err` value: "invalid language"
```

For a library, I don't think we should panic on an invalid language here, but instead ignore it or assume a default.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.