harfbuzz / harfbuzz/harfbuzzjs
Review usage of ValueOf
Open
- Dominant language
- TypeScript
- Stars
- 286
- Forks
- 48
- Avg merge
- 5h 15m
- Merged PRs (30d)
- 3
Description
Values of these two objects are not known statically, therefore the usage of `ValueOf` and the resulted types aren’t quite useful:
https://github.com/harfbuzz/harfbuzzjs/blob/e55f3ce887a1a5437d8e7a3a3730123c7a49a5f6/src/buffer.ts#L70
https://github.com/harfbuzz/harfbuzzjs/blob/e55f3ce887a1a5437d8e7a3a3730123c7a49a5f6/src/font.ts#L79
Were the values meant to be string literals like `"hasc"` instead of dynamically converted numbers like `hb_tag("hasc")`?
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.