hardbyte / hardbyte/python-can

ASCReader does not support ASC format since V8.1

Open
#1,531 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
1.6k
Forks
697
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug

ASCReader in python-can 4.1.0 doesn't support ASC CANFD format since V8.1, since \ name is missing in code.
According to the document from Vector , there should be \ between \ and \.

### To Reproduce

Use python-can to read CANFD message in asc log since format V8.1.

### Expected behavior

Reading process stopped with CANFD message.

### Additional context
I made a quick fix in a forked [branch](https://github.com/Tian-Jionglu/python-can/tree/asc_quick_fix).
I think an overall fix about ASC format IO is needed in this issue.

OS and version:
Python version:
python-can version:
python-can interface/s (if applicable):

Traceback and logs

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.