hapijs / hapijs/joi

Breaking change with .extend()

Open
#2,671 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
21.2k
Forks
1.5k
Avg merge
4h 57m
Merged PRs (30d)
14

Description

The docs fail miserably at explaining how to extend Joi.

When you google how to create extensions for Joi there are hundreds of posts and libraries that have code just like the one posted in [this issue](https://github.com/sideway/joi/issues/2453#issue-684440919).

This one in particular [@meanie/joi-country](https://github.com/meanie/joi-country/blob/master/index.js) has `"Joi": "^17.0.0 "` in it's package.json but the library doesn't even work with the current version `17.4.2`.

Here's a codesanbox showing how it fails with `.country is not a function`: https://codesandbox.io/s/amazing-cerf-hwjo0?file=/src/index.js

Was there a breaking change without a major semver increase?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.