hans / hans/ipython-notebooks

Minor issue in Seq2Seq tutorial

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
149
Forks
44
PR merge metrics
No merged PRs in 30d

Description

First of all, I would like to thank you! Browsing around the net could not find a seq2seq model as clear as yours. Nonetheless, I believe there is a minor issue in ipython-notebooks/tf/TF tutorial.ipynb In [26] the line:

`dec_inp = ([tf.zeros_like(enc_inp[0], dtype=np.int32, name="GO")]+ enc_inp[:-1])`

Should be:

`dec_inp = ([tf.zeros_like(labels[0], dtype=np.int32, name="GO")] + labels[:-1])`

This will enable you to have different sequence lengths and vocab sizes for dec_inp and enc_inp.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.