handsontable / handsontable/hyperformula
Flaky tests: NOW() tests are failing on Safari
Open
Nobody has claimed this yet.
Tests
Verified
- Dominant language
- TypeScript
- Stars
- 2.8k
- Forks
- 171
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 7
Description
Description
4424 specs, 2 failures, 4 pending specs
Interpreter - function NOW > works
Expected 31275.2399652778 to be close to 31275.1565856481.
Interpreter - function NOW > works #5
Expected 5 to equal 3.
We've used Date.parse as a date mock
As it turned out, Safari parses date differently than all other browsers.
- Don't use
Date.parse - Adding seconds with
cnt++will eventually run out of range for seconds and fail in every browsers
Steps to reproduce
- Run tests on Safari
Your environment
- HyperFormula version: develop
- Browser Name and version: Safari
- Operating System: Mac OSX
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/interpreter/function-now.spec.ts, especially the referenced lines, and run the NOW function specs in Safari. Replace the Date.parse-based mock and avoid the seconds counter running out of range; done means the tests pass reliably in Safari and other browsers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100