handsontable / handsontable/hyperformula

Automatic upsizing, no automatic downsizing.

Open
#622 0 comments 0 reactions 1 assignee View on GitHub

@izulin is already working on this.

Since Apr 3, 2021.

Question To Be Discussed Verified
Dominant language
TypeScript
Stars
2.8k
Forks
171
Avg merge
1d 22h
Merged PRs (30d)
7

Description

Description

Right now we upsize the sheet size whenever necessary:

    const hf = HyperFormula.buildEmpty()
    hf.setCellContents({sheet: 0, row: 100, col: 100}, 0)
    console.log(hf.getSheetDimensions(0))

produces { width: 101, height: 101 }

however

    hf.setCellContents({sheet: 0, row: 100, col: 100}, undefined)
    console.log(hf.getSheetDimensions(0))

still produces { width: 101, height: 101 }

There is no easy way of de-allocating the sheet (if one uses dense mapping, this memory is actually allocated as an array),
besides e.g. serializing and de-serializing of the engine (e.g. config update with no config change).

Still, this would be a non-trivial task to implement, and of negligible gain, so it should be rather reflected in a change to known limitations.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.