handsontable / handsontable/hyperformula
We're missing tests for EmptyStatistics
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.8k
- Forks
- 171
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 7
Description
Description
EmptyStatistics class is used for production build by default:
But our tests are always using Statistics module:
We should close this functionality with a test or two, to ensure that we're not using stats in the default production build.
Statistics are not cleared, they are for debugging only and may be a memory leak if used for a longer time than a short debugging session.
Your environment
- HyperFormula version: 0.1.2
- Browser Name and version: Firefox
- Operating System: OS X
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/BuildEngineFactory.ts at the production statistics setup and compare it with test/_setupFiles/bootstrap.ts, which currently uses Statistics. Add one or two tests confirming the default production build uses EmptyStatistics rather than collecting statistics, then run the relevant test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100