handsontable / handsontable/hyperformula

Add cellAddress to "Value of the formula cell is not computed." error message

Open
#444 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Verified
Dominant language
TypeScript
Stars
2.8k
Forks
171
Avg merge
1d 22h
Merged PRs (30d)
7

Description

Description

We should add a cell address to the error message so we can trace the source of this error more easily.

https://github.com/handsontable/hyperformula/blob/508e4e4d9961473a35686354f46e3162be2cd53e/src/DependencyGraph/FormulaCellVertex.ts#L74

A simple JSON.stringify should do. ie:

throw Error(`Value of the formula cell is not computed for: ${JSON.stringify(this.cellAddress)}`)

TODO:

  • Add this.cellAddress to the error message
  • Check if this.formula will be usefull here as well
  • Check if this.cellAddress should be better formatted than stringify

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/DependencyGraph/FormulaCellVertex.ts around line 74 and inspect the existing error construction and cellAddress representation. Confirm the error identifies the formula cell, then check the surrounding tests or error-handling expectations and resolve whether the formula or a different address format is also needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.