handsontable / handsontable/hyperformula

Error when trying to move columns when `maxColumns` limit is set tightly

Open
#1,185 0 comments 0 reactions 1 assignee View on GitHub

@sequba is already working on this.

Since Mar 9, 2023.

Bug Impact: Medium
Dominant language
TypeScript
Stars
2.8k
Forks
171
Avg merge
1d 22h
Merged PRs (30d)
7

Description

Description

Method moveColumns does not change the number of columns in a sheet. But when maxColumns limit is set tightly, this operation produces error:

Error: Sheet size limit exceeded

Also, we need to check other methods if they work correctly on tight limits of row/column number.

Demo

https://codesandbox.io/s/priceless-violet-idjjj9?file=/src/hyperformulaConfig.js:566-594

Links

https://handsoncode.slack.com/archives/C04TGV7MXMX/p1678354787330359 (internal, accessible by @sequba, @adamu-handsontable and @wszymanski)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.