handsontable / handsontable/hyperformula
[Refactor] Visitor design pattern for algorithms that traverse the AST tree
Open
@sequba is already working on this.
Since Mar 1, 2023.
Impact: Medium
Tech Debt
- Dominant language
- TypeScript
- Stars
- 2.8k
- Forks
- 171
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 7
Description
Description
As pointed out in https://github.com/handsontable/hyperformula/pull/1159#discussion_r1119354105 we should refactor methods that traverse the AST tree. This code pattern is repeated a few times in our project. I suggest using the visitor design pattern. It will make the code cleaner and improve maintainability.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.