handsontable / handsontable/hyperformula
Define the importable files through `exports` property in `package.json`
@sequba is already working on this.
Since Jan 13, 2023.
- Dominant language
- TypeScript
- Stars
- 2.8k
- Forks
- 171
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 7
Description
Description
Publint reports for all files in /es/ directory:
pkg.module is used to output ESM, but pkg.exports is not defined. As NodeJS doesn't read pkg.module, the ESM output may be skipped. Consider adding pkg.exports to export the ESM output. pkg.module can usually be removed alongside too. (This will be a breaking change)
We can fix it by adding the exports property to package.json.
It should probably be done together with #1086
Warning: this change might be considered breaking.
HOT team did a similar task in https://github.com/handsontable/handsontable/pull/7403 & https://github.com/handsontable/handsontable/pull/8875/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
Links
- https://handsoncode.slack.com/archives/C4PV4S33Q/p1673602200151429 (internal discussion)
- #1086
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.