handshake-org / handshake-org/urkel

Proof fields not used.

Open
#8 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
124
Forks
21
PR merge metrics
No merged PRs in 30d

Description

`proof.isSane()` checks for nil values for the type `deadend`. Is there even a need for this? Looking through the code it appears there's no possible way for `key,value,hash` to ever be set for `deadend`. Is it simply good enough to check for the type without testing the unused fields? Or are these fields placeholders for future reference?

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate proof.isSane() and the deadend proof representation, then trace whether key, value, and hash can ever be populated for that type. Review how deadend proofs are constructed and validated. The work is complete when the intended handling of these unused fields is decided and the validation behavior consistently reflects that decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cryptography, databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.