handshake-org / handshake-org/hsd

wallet: Add `abortOnClose` parameter to tx sending endpoints

Open
#848 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.1k
Forks
306
PR merge metrics
No merged PRs in 30d

Description

Big wallets, with lots of coins, or big transactions that needs lots of coins can take a some time to craft transactions before broadcasting. We get compounding effect when we use fundLocks where multiple requests are also queued.
So allowing new request parameter abortOnClose can work by making sure that transaction creation is done before request closes. If request closes and transaction already was being sent, it will do nothing.

#845

Contributor guide

Open the contributing guide

Research direction

Start by locating the wallet transaction-sending endpoints and their request-close handling; the issue does not name files or tests. Trace how transaction creation and fundLocks are queued, then verify that abortOnClose completes creation before the request closes and has no effect when sending has already started.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.