handshake-org / handshake-org/hsd
chain: double check invalidate operaiton
Open
- Dominant language
- JavaScript
- Stars
- 2.1k
- Forks
- 306
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/handshake-org/hsd/blob/914f62520d8c2fdbdd45af6bcd6954629623609f/lib/blockchain/chain.js#L2102-L2105
I wonder if we should `invalidate` before we `replay`?
see also
https://github.com/bcoin-org/bcoin/issues/277
and
https://github.com/bcoin-org/bcoin/pull/276
Contributor guide
Assessment
This issue has not been assessed yet.