handshake-org / handshake-org/hsd

HSD does not properly support EDNS.

Open
#560 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.1k
Forks
306
PR merge metrics
No merged PRs in 30d

Description

dig using the authoritative nameserver for rasor
```
seb@t480 ~/documents/repos/bob-wallet % dig +edns=100 +noednsneg soa rasor @45.77.111.169

; <<>> dig 9.10.8-P1 <<>> +edns=100 +noednsneg soa rasor @45.77.111.169
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: BADVERS, id: 48724
;; flags: qr rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;rasor. IN SOA

;; Query time: 46 msec
;; SERVER: 45.77.111.169#53(45.77.111.169)
;; WHEN: Fri Feb 12 19:42:07 CST 2021
;; MSG SIZE rcvd: 34
```

dig using hsd
```
seb@t480 ~/documents/repos/bob-wallet % dig +edns=100 +noednsneg soa rasor @140.82.4.75

; <<>> dig 9.10.8-P1 <<>> +edns=100 +noednsneg soa rasor @140.82.4.75
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 57285
;; flags: qr rd ra ad; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 2

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;rasor. IN SOA

;; ANSWER SECTION:
rasor. 235 IN SOA rasor. sebastian.rasor. 2021020401 900 900 1800 60

;; SIG0 PSEUDOSECTION:
. 0 ANY SIG RESERVED0 253 0 0 20210213074131 20210212194131 4794 . 2X5evAFQ3uxbhoL9a47Q2VJ3XaIdAW8W8o61tLuZgmBpBFRZjVn7ovqw 3P+PFww9nLeRoX0p17/HNA0LWeF/mQ==

;; Query time: 50 msec
;; SERVER: 140.82.4.75#53(140.82.4.75)
;; WHEN: Fri Feb 12 19:41:31 CST 2021
;; MSG SIZE rcvd: 174
```

`options edns0` is in the resolv.conf of both my local machine and the Ubuntu server running HSD.

when passing a bad EDNS version, it is expected to see a status of BADVERS like in the first command response. instead HSD is returning NOERROR and processing the request like usual. See RFC6891, 6.1.3. OPT Record TTL Field Use

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.