handshake-org / handshake-org/hsd

Network protocol is outdated: pruned node services

Open
#536 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.1k
Forks
306
PR merge metrics
No merged PRs in 30d

Description

This is a port of issue https://github.com/bcoin-org/bcoin/issues/721

Most importantly, it prevents pruning nodes from broadcasting blocks and that also includes MINERS that are using pruned nodes:

https://github.com/handshake-org/hsd/blob/1a086e44b5b60e1ebb01955b0e1b2a0ebd00b42d/lib/net/pool.js#L1146-L1159

We can adopt [BIP159](https://github.com/bitcoin/bips/blob/master/bip-0159.mediawiki) which adds a service bit to the protocol to signal a node has limited blocks to share.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.