handshake-org / handshake-org/hsd

test: add get network group tests to tests/net

Open
#310 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.1k
Forks
306
PR merge metrics
No merged PRs in 30d

Description

opening this issue to track the request from here: https://github.com/handshake-org/hsd/pull/217

That PR includes all of the "static" tests to network addresses' getGroup() function. While that is a good start, it might be prudent for us to eventually build a test that ensures we are not adding 2 peers who exist in the same network group to our outbound connections. This requires more of a live simulation environment than what is provided in the current net address tests.

Contributor guide

Open the contributing guide

Research direction

Start in tests/net and review the static network-address getGroup() tests from PR #217. Then determine how the networking tests can provide a live simulation of outbound connections. Done means coverage showing that two peers from the same network group are not both added to outbound connections.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
networking, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.