handshake-org / handshake-org/hsd

Custom inspection function on Objects via .inspect() is deprecated

Open
#225 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.1k
Forks
306
PR merge metrics
No merged PRs in 30d

Description

This deprecation error was handled in bcoin in https://github.com/bcoin-org/bcoin/pull/715

Looks like most of the big objects in hsd bypassed this issue by extending `bio.struct` in https://github.com/handshake-org/hsd/commit/d4782e0cc115042816b710c56ebf4b6be2672a76, which in turn was fixed here: https://github.com/bcoin-org/bufio/commit/da320cf5554b00fe73ca2c6be04b705c58a8a538

A quick grep of hsd for `inspect()` returned 27 matches across 15 files.

I can make a PR for this soon, just opening an issue now as a TODO.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the 27 `inspect()` matches across 15 hsd files, then compare the handling in bcoin pull request 715 and the referenced bufio fix. Done means updating the affected custom inspection uses so the deprecation is handled consistently across hsd.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.