handshake-org / handshake-org/hs-client

hsw-cli should (?) filter environment variables for wallet-*

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
88
Forks
38
PR merge metrics
No merged PRs in 30d

Description

To reproduce:

start hsd with custom ports:
`$ hsd --network=regtest --memory=true --http-port=10000 --wallet-http-port=20000`

set environment variables:
```
$ export HSD_HTTP_PORT=10000
$ export HSD_WALLET_HTTP_PORT=20000
```

make client calls:
```
$ hsd-cli info # success
$ hsw-cli wallets # fails, gets redirected to NODE HTTP PORT (10000)
# hsw-cli wallets --http-port=20000 # success
```

so, `hsw-cli` might want to filter environment variablels to correctly parse `WALLET_HTTP_PORT`

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the hsw-cli entry point and reproduce the commands with HSD_HTTP_PORT and HSD_WALLET_HTTP_PORT set as shown. Trace how hsw-cli reads the environment and compare it with the explicit --http-port behavior; done means hsw-cli wallets uses the wallet HTTP port without requiring the flag.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.