handshake-org / handshake-org/hs-client

i promised to fix unlock behavior

Open
#47 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
88
Forks
38
PR merge metrics
No merged PRs in 30d

Description

https://discord.com/channels/822591034202521641/956214168170684476/957872183047254036

lukeburns/ — Today at 10:22 PM
i mean for the wallet.unlock(pass, timeout) method
it spits out { succeed: true } for pass i put in
which is not informative
if it's already unlocked, then it didn't succeed
pinheadmz — Today at 10:22 PM
Fix it then
lukeburns/ — Today at 10:23 PM
good idea
i will do that
but not now
😉
so it goes

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the wallet.unlock(pass, timeout) method and inspect how it responds when the wallet is already unlocked. Confirm the intended result for that case, then add coverage showing that an already-unlocked wallet is not reported as a successful unlock.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.