handshake-org / handshake-org/handshake-org.github.io

fee rate is whole HNS

Open
#138 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
81
Forks
65
PR merge metrics
No merged PRs in 30d

Description

https://hsd-dev.org/api-docs/?shell--cli#send-a-transaction

```
the rate for transaction fees. Denominated in subunits per kb
```

I don't think this is right. Internally in hsd, `rate` is treated as an int, a number of dollarydoos. But actually what you enter into `hsw-cli` is a float, that gets multiplied `*10e6`:

https://github.com/handshake-org/hs-client/blob/533b1403f381c086fc364545d88410fc38e8c0f4/bin/hsw-cli#L375

```
rate: this.config.ufixed('rate', EXP),
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.