hagopj13 / hagopj13/node-express-boilerplate
Why doesn't the UserSchema's password validation uses the password definition in custom.validation.js?
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 7.7k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
The password validation in the user.model.js file is identical to the one defined in custom.validation.js.
Is this code duplication by design or an oversight?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the password validation in user.model.js with the definition in custom.validation.js, starting from the UserSchema validation. Determine whether the duplication is intentional; done requires resolving the design question and identifying the affected validation definition if maintainers choose to consolidate it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100