hagopj13 / hagopj13/node-express-boilerplate

Why doesnt the userModel contain the salt?

Open
#188 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
7.7k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

The user.fixture.js file includes a salt for the admin but it doesnt seem to be stored anywhere. Why not add the salt to the user model? It's solely for preventing rainbow table attacks, no issue in storing it right next to the password.

Any reason for this?

Contributor guide

Open the contributing guide

Research direction

Start by reading user.fixture.js and the issue’s description of password salts. Trace where the user model and password handling are defined, then clarify whether storing the salt is intended and what behavior should be tested; the issue names no test or acceptance criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
express, javascript, mongodb, nodejs
Domain
authentication, backend, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.