hadley / hadley/data-diff

Add tolerant double comparison

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
27
Forks
0
Avg merge
53m
Merged PRs (30d)
1

Description

Allow optional non-negative relative and absolute tolerances for reporting floating-point cell changes.

For finite x and y, compare equal when:

|x - y| <= max(t_abs, t_rel * max(|x|, |y|))

Requirements:

  • Both tolerances default to zero.
  • Tolerance applies only to cell-level value-change reporting.
  • Key matching, hashing, and rename inference remain exact because approximate equality is not transitive.
  • The UI displays active tolerances so omitted small differences are explainable.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the cell-level value-change reporting path and the UI that presents differences. Implement zero-default non-negative absolute and relative tolerances only for value changes, while keeping key matching, hashing, and rename inference exact; done means active tolerances are visible in the UI and the stated finite-value comparison rule is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.