hackmdio / hackmdio/hackmd-io-issues

Disqus fails to load when the shortname includes a hyphen

Open
#239 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
40
Forks
9
PR merge metrics
No merged PRs in 30d

Description

### Is this a hackmd.io issue?

- [x] Yes, the bug happens on https://hackmd.io

### What's the problem

#### Current behaviour

If your disqus shortname includes a hyphen (`-`), the comments will fail to load, yielding instead:

> We were unable to load Disqus. If you are a moderator please see our troubleshooting guide

### Provide steps to reproduce:

1. Create a disqus site with a shortname that has a hyphen, e.g.: "hackmd-disqus"
2. Try to add it to a note via `disqus: hackmd-disqus`
3. Load the note preview
4. See error

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.