hackmdio / hackmdio/hackmd-io-issues

disq.us shortener doesn't support @ in url

Open
#216 1 comment 0 reactions 0 assignees View on GitHub
upstream
Dominant language
No language data
Stars
40
Forks
9
PR merge metrics
No merged PRs in 30d

Description

### Is this a hackmd.io issue?

- [x] Yes, the bug happens on https://hackmd.io but related to the _Disqus API_

### What's the problem

#### Current behaviour
Sharing trough the embedded _Disqus_ service producing 404Error because of _URL encoding_

> ![image](https://user-images.githubusercontent.com/4000929/98485452-1e24f080-221f-11eb-8e84-0bf6c0136141.png)
> ![image](https://user-images.githubusercontent.com/4000929/98485449-19603c80-221f-11eb-825a-91c4edaa3c43.png)

Provide steps to reproduce:

1. Go to https://hackmd.io/@eaposztrof/Call2Action-COVFREE21#disqus_thread
2. Click on Twitter/Facebook share
3. The provided URL shorteners produce 404 Error because of '@' in hackmd.io's URL.

#### Environment
I use HackMD on:

**Desktop**
- OS: Win10
- Browser: chrome

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.