hackmdio / hackmdio/codimd

Update `@aws-sdk/client-s3-node` (deprecated preview) to `@aws-sdk/client-s3` (v3 stable)

Open
#1,956 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10.1k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

## Problem

CodiMD uses `@aws-sdk/client-s3-node` v0.1.0-preview.2 for S3 image uploads. This package was a preview release of AWS SDK v3 and has since been renamed to `@aws-sdk/client-s3` upon its stable release.

The preview package is no longer maintained and receives no bug fixes or security patches.

## Proposed Solution

Update the deprecated preview package to the currently maintained stable release.

| | Current | Proposed |
|---|---|---|
| Package | `@aws-sdk/client-s3-node` | `@aws-sdk/client-s3` |
| Version | `0.1.0-preview.2` | `^3.x` (latest stable) |

The module structure changed between the preview and stable releases, so the import paths in `lib/imageRouter/s3.js` will also need to be updated.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.