hackforla / hackforla/website

Epic: Create Issues to audit codebase for img tags ending with a slash

Open
#4,922 28 comments 0 reactions 0 assignees View on GitHub
Complexity: See issue making label Draft epic Feature: Refactor HTML Issue Making: Level 2 ready for product role: front end size: 1pt
Dominant language
JavaScript
Stars
363
Forks
872
Avg merge
2d 21h
Merged PRs (30d)
18

Description

### Overview
We want to change each img HTML tag ending with a slash () in the HfLA codebase to an img tag without an ending slash (). An issue template and instructions will be prepared, in order to facilitate the creation of issues for performing the audit across the entire codebase. Each new issue will audit a single file and results will be stored in the HfLA-Website: img Tag Audit spreadsheet.

### Action Items
- [x] Make an issue template to audit, find, and document instance of `` in each file in the HfLA-Website: img Tag Audit spreadsheet[^1]
- [x] This issue template will include a "Complexity: Small" label and a "ready for dev lead" label along with all the other needed labels.
- [x] Review and (if needed) edit the following in the HfLA-Website: img Tag Audit spreadsheet:
- [x] "Instructions for Page Audit Issue Writers" section on the Instructions tab [^1]
- [x] Page Audit tab [^2]. All the files that still need to be audited are already listed in the Page Audit tab.
- [x] img with Ending Slash tab [^3]. This tab contains the lines of code with that have been found so far. This tab will also be where developers auditing the files add their findings.
- [x] Use the template to make one issue as an example
- [x] Get approval from a PM on the template.

### Resources/Instructions
[^1]: [HfLA-Website: img Tag Audit spreadsheet](https://docs.google.com/spreadsheets/d/1cq8iLOYQkAbho2GsRAxVJYgjxDeJ9KLdx2NuL4G6vu4/edit#gid=1822415835)
[^2]: HfLA-Website: img Tag Audit spreadsheet's [Page Audit tab](https://docs.google.com/spreadsheets/d/1cq8iLOYQkAbho2GsRAxVJYgjxDeJ9KLdx2NuL4G6vu4/edit#gid=1277680545&fvid=1305214134)
[^3]: HfLA-Website: img Tag Audit spreadsheet's [img with Ending Slash tab](https://docs.google.com/spreadsheets/d/1cq8iLOYQkAbho2GsRAxVJYgjxDeJ9KLdx2NuL4G6vu4/edit#gid=0&fvid=959329398)
[^4]: Issue Template 1: [img Tag Refactor on Website](https://github.com/hackforla/website/issues/new?assignees=&labels=Feature%3A+Refactor+HTML%2C+good+first+issue%2C+ready+for+dev+lead%2C+role%3A+back+end%2FdevOps%2C+role%3A+front+end%2C+size%3A+0.25pt&template=img-tag-refactor-on-website.md&title=img+Tag+Refactor%3A+%5BINSERT+PAGE+HERE%5D+page%28s%29) and its associated Markdown file [.github/ISSUE_TEMPLATE/img-tag-refactor-on-website.md](https://github.com/hackforla/website/blob/gh-pages/.github/ISSUE_TEMPLATE/img-tag-refactor-on-website.md). This template works for any pages that is marked with `Template 1` in the `Template to use if found` column on the `Page Audit` tab . Template 1 works if the img tag is on the website.

- This epic resulted from #4362

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.