hackforla / hackforla/website

Epic: Change to Wins Form, Apps Script and JS to implement new URL validation strategy

Open
#4,671 1 comment 0 reactions 0 assignees View on GitHub
Complexity: Large Complexity: Medium Dependency Draft epic P-Feature: Wins Page role: back end/devOps role: front end size: 1pt size: 2pt
Dominant language
JavaScript
Stars
363
Forks
872
Avg merge
2d 21h
Merged PRs (30d)
18

Description

### Dependencies
The following issues are part of this epic
- [x] #4595
- Modify the Google Form with regex-based validation for the GitHub and LinkedIn URL fields
- Accept a variety of inputs that match common formats, for example those with protocol 'http://', 'https://' or no protocol, and similarly to accept domain names with or without the 'www' prefix.
- [x] #5472
- [x] #5470

### Overview
As developers we need to first implement a strategy for collecting the GitHub and LinkedIn URLs in a manner that is user-friendly and secondly to store the essential part of those URLs (the profile descriptors) in an efficient and reusable manner, and finally to ensure a consistent appearance of the URLs on the Wins webpage.

### Resources/Instructions
- See #4185
Bonnie's explanation of what we are trying to accomplish

How is the page code interpreting and or rationalizing the urls being provided. (e.g., Is it taking everything with http and transforming it into https? etc.)

What I am getting at is, that we should clean the url string before it gets to the data store, if at all possible. So if we want to store just the username for inkedin and github that is ok. if we want to store the whole string, then the string should be formatted with https: without the www even though linkedin allows either with or without the www.

https://www.linkedin.com/in/bonnieawolfe
https://linkedin.com/in/bonnieawolfe
But at the same time, we don't want to make it hard for the person entering the info, so we will accept any version of the input but must store it uniformly.

http://linkedin.com/in/bonnieawolfe
https://linkedin.com/in/bonnieawolfe
http://www.linkedin.com/in/bonnieawolfe
https://linkedin.com/in/bonnieawolfe
And then we would need a script after the fact that cleans the data turning it into either (my preference being just the username)

https://linkedin.com/in/bonnieawolfe
bonnieawolfe

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.