hackforla / hackforla/tdm-calculator

Product: Refine action menu behavior for Deleted TDM Plans

Open
#3,084 29 comments 0 reactions 1 assignee Claimed by @ngorokh View on GitHub
deck: stakeholder presentation feature: Stakeholder options level: easy p-feature: My Projects p-feature: My Projects-Deleted Tab priority: MUST HAVE ready for product role: Product Management size: 0.5pt
Dominant language
JavaScript
Stars
68
Forks
47
Avg merge
3d 9h
Merged PRs (30d)
25

Description

### Overview
We need to define correct action menu behavior on the My TDM Plans page for Deleted TDM Plans (both Draft and Snapshot states)

#### Details
- On the My TDM Plans page, within the Deleted TDM Planss tab, the current action menu includes actions that may not be applicable for deleted items, especially in cases involving shared snapshots.
- This issue aims to define the correct behavior for actions on deleted TDM Plans, including edge cases such as shared snapshots and project lifecycle constraints.

### Action Items
- [x] List all potential actions and review and define which actions should be available for Deleted TDM Plans
- [x] Clarify behavior for shared snapshots when deleted
- [x] Decide whether deletion of shared snapshots should be allowed or restricted
- [x] Define UX behavior (e.g., modal) if user must unshare before deletion
- [x] Align behavior across project states (Draft, Snapshot, Deleted)
- [x] Review with product and dev. Update if needed based on feedback
- [x] Once recomendation is finalized, add before and after images to the slide in the staging deck for this issue (see link under resources)
- [x] Get Stakeholder sign-off via the stakeholder meeting slide deck.
- [x] Create issue to remove or disable invalid actions from Deleted Projects action menu

### Key Questions
- Should a snapshot that is shared with others be deleted?
- If no, should the system require unsharing before deletion?
- if yes, "Share" menu item would need to remain available for deleted projects so that people could stop sharing on the related modal.
- Should hidden state persist after deletion and restoration?
- Example scenario:
- A user deletes a hidden project from the "My TDM Plans" view.
- The project moves to the Deleted tab as a hidden project.
- When the user restores it, it returns as hidden.
- However, since the default "My TDM Plans" view shows only visible items, the restored project is not shown, which may confuse the user.
Logic:
Restoring a project implies the user intends to access and work with it. Therefore, the project should be visible by default after restoration. If the user prefers to keep it hidden, they can hide it again.

- Should a deleted project be duplicated?
- If yes, the current behavior: a duplicate is created in the Active TDM Plans tab, while the original remains in the Deleted TDM Plans tab.
- If no, we will remove it from the menu

**Current behavior**
- What happens to shared access if a TDM Plan is deleted?
- log in as user 2
- share TDM Plans with user
- user 2 deletes the TDM Plans (please note the id)
- log in as user
- find TDM Plans (look on my projects tabs: active TDM Plans, deleted TDM Planss)
- note where the TDM Plans was
- Observed behavior: the shared TDM Plans is automatically moved to the "Deleted" tab for the other user when deleted by the owner.
- see what you as user, can do with project. Can you
- [ ] undelete
- [x] duplicate
- [ ] share with someone else (admin)
- [ ] view it (clicking on link takes you to page 5)
- [x] export it
- [x] print it
- [ ] delete it
- [ ] rename (if thats even available on shared with you snapshots)
- [x] hide

~Proposed behavior~ This is covered above
~When a user attempts to delete a shared TDM Plans, it should prompt them to unshare.~

#### Deleted Snapshot
Current actions:
- Rename Snapshot
- Share Snapshot
- Submit Snapshot
- Print Summary
- Export as CSV
- Duplicate
- Hide
- Restore from Trash

Action menu for Deleted Snapshot

Image

Proposed behavior:
- Rename Snapshot
Not expected to be available for deleted items, as editing should not be allowed
- Share Snapshot
- with a new person
Should not be available for deleted items
- already shared with another user
Requires decision
Keep the Share modal for unsharing existing users, but disable sharing with new users for deleted items.

Share Snapshot modal

Image

- Submit Snapshot
Should not be available for deleted items
- Print Summary
Can remain available as a read-only action
- Export as CSV
Can remain available as a read-only action
- Duplicate
Requires decision
There is a use case where users may want to create a copy before permanent deletion
- Hide
Requires decision
May not be relevant within the Deleted Projects context
- Restore from Trash
Should remain available as the primary recovery action

#### Deleted Draft

Current actions:
- Convert to Snapshot
- Print Summary
- Export as CSV
- Duplicate
- Hide
- Restore from Trash

Action menu for Deleted Draft

Image

Proposed behavior:
- Convert to Snapshot
Not expected to be available for deleted items
- Print Summary
Can remain available as a read-only action
- Export as CSV
Can remain available as a read-only action
- Duplicate
Requires decision
Could be useful to recover work before permanent deletion
- Hide
Requires decision
Likely redundant in the Deleted TDM Plans context
- Restore from Trash
Should remain available as the primary recovery action

### Resources/Instructions
REPLACE THIS TEXT -If there is a website which has documentation that helps with this issue provide the link(s) here.

#### Staging and Release decks
- [Staging Deck](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/)
- ~[Staging slide, 3084, slide 1](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_74#slide=id.g3d5195a6788_10_74)~
- ~[Staging slide, 3084, slide 2](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_0#slide=id.g3d5195a6788_10_0)~
- ~[Staging slide, 3084, slide 3](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5260dc06c_2_2#slide=id.g3d5260dc06c_2_2)~
- ~[Staging slide, 3084, slide 4](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_54#slide=id.g3d5195a6788_10_54)~
- ~[Staging slide, 3084, slide 5](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_7#slide=id.g3d5195a6788_10_7)~
- ~[Staging slide, 3084, slide 6](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_41#slide=id.g3d5195a6788_10_41)~
- ~[Staging slide, 3084, slide 7](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_27#slide=id.g3d5195a6788_10_27)~
- ~[Staging slide, 3084, slide 8](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_20#slide=id.g3d5195a6788_10_20)~
- ~[Staging slide, 3084, slide 9](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d6256c4f4c_6_39#slide=id.g3d6256c4f4c_6_39)~
- ~[Staging slide, 3084, slide 10](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_34#slide=id.g3d5195a6788_10_34)~
- ~[Staging slide, 3084, slide 11](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_48#slide=id.g3d5195a6788_10_48)~
- ~[Staging slide, 3084, slide 12](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d5195a6788_10_62#slide=id.g3d5195a6788_10_62)~
- ~[Staging slide, 3084, slide 13](https://docs.google.com/presentation/d/1crZ3IxqA4hAu3qzD7ns93Ieuqjwh6wyEtuX_46cP-fg/edit?slide=id.g3d6256c4f4c_6_33#slide=id.g3d6256c4f4c_6_33)~
- Release Deck
- [2026-04-14 Release deck, 3084, slide 1](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_0#slide=id.g3de98b206b0_1_0)
- [2026-04-14 Release deck, 3084, slide 2](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_8#slide=id.g3de98b206b0_1_8)
- [2026-04-14 Release deck, 3084, slide 3](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_17#slide=id.g3de98b206b0_1_17)
- [2026-04-14 Release deck,3084, slide 4](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_25#slide=id.g3de98b206b0_1_25)
- [2026-04-14 Release deck,, 3084, slide 5](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_30#slide=id.g3de98b206b0_1_30)
- [2026-04-14 Release deck,, 3084, slide 6](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_36#slide=id.g3de98b206b0_1_36)
- [2026-04-14 Release deck,, 3084, slide 7](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_42#slide=id.g3de98b206b0_1_42)
- [2026-04-14 Release deck, 3084, slide 8](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_48#slide=id.g3de98b206b0_1_48)
- [2026-04-14 Release deck, 3084, slide 9](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_54#slide=id.g3de98b206b0_1_54)
- [2026-04-14 Release deck, 3084, slide 10](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_60#slide=id.g3de98b206b0_1_60)
- [2026-04-14 Release deck,, 3084, slide 11](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_66#slide=id.g3de98b206b0_1_66)
- [2026-04-14 Release deck, 3084, slide 12](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_72#slide=id.g3de98b206b0_1_72)
- [2026-04-14 Release deck, 3084, slide 13](https://docs.google.com/presentation/d/1qD8M1rGe-qZuRs6ddjZMNlPsf9zEK98MaVlM45HsPTY/edit?slide=id.g3de98b206b0_1_78#slide=id.g3de98b206b0_1_78)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.