hackforla / hackforla/peopledepot

review all comments in code after all tables are created

Open
#499 0 comments 0 reactions 0 assignees View on GitHub
complexity: large epic feature: update table ready for dev lead role: dev lead s: PD team size: missing
Dominant language
Python
Stars
14
Forks
37
Avg merge
9d 15h
Merged PRs (30d)
5

Description

### Dependency
- [ ] [All the tables having been created and updated](https://github.com/hackforla/peopledepot/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22feature%3A%20table%20creation%22%2C%22feature%3A%20update%20table%22) - clicking the link should render 0 results

### Overview

Review all commented lines of code after all tables are created to see if they should be deleted or uncommented, so that the tables can be considered delivered.

#### Details
As we have been making the tables, We commented out FKs where the referenced table was not yet created. There might also be other reasons for comments.
- This issue was created because of this comment https://github.com/hackforla/peopledepot/issues/432#issuecomment-2617111894

### Action Items
- [ ] review the code base and identify either individual files or folders that all the files need to be reviewed in
- [ ] Either make the changes, or make issues for each file or groups of files to be changed

### Resources/Instructions
- Spreadsheet: [PD: Table and field explanations, Current Field Permission tab](https://docs.google.com/spreadsheets/d/1x_zZ8JLS2hO-zG0jUocOJmX16jh-DF5dccrd_OEGNZ0/edit?gid=749942651)

#### Files that need to be reviewed
- https://github.com/hackforla/peopledepot/blob/main/app/core/models.py

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.