hackforla / hackforla/VRMS

Epic: Improve integrations for react-hook-form across components

Open
#1,481 3 comments 0 reactions 0 assignees View on GitHub
complexity: medium Epic/Overview feature: Form Validation role: Front End size: 0.25pt
Dominant language
JavaScript
Stars
61
Forks
101
PR merge metrics
No merged PRs in 30d

Description

### Overview
Outline of steps to integrate react-hook-form's validation more seamlessly, so that we write cleaner, more reusable code, with a single way of achieving form validaiton across the project.

### Context
Validation has been a sticking point for this project, but thanks to the hard work of the devs on this team we're moving towards having this portion of our app handled. We've still got a bit to go, this issue is going to outline the steps to take to integrate react-hook-form's validation more seamlessly.

### Action Items
- [x] #1482
- [x] #1483
- [x] Remove duplicates of simpleInput other places in the app eg `addProjcet` and `editProject`
- [x] Replace the above with import of simpleInput
- [x] #1484
- [ ] Merge validation functions made by @evanyang1
- [ ] Potentially adapt validation functions to fit react-hook-form validate format
- [ ] Adapt simpleInput to contain a validations array that will be consumed by ValidatedTextField
- [ ] Adapt simpleInput and ValidatedText field to accept helper form fields eg radio buttons

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.