hackforla / hackforla/311-data

PRD - Incorporate label "ready for peer review" into weekly checks

Open
#2,027 2 comments 0 reactions 0 assignees View on GitHub
Feature: General Management Good First Issue on agenda: pm ready for product Role: Product Management size: 0.25pt
Dominant language
JavaScript
Stars
73
Forks
74
PR merge metrics
No merged PRs in 30d

Description

### Overview
We need to add the "ready for peer review" label to our processes for weekly checks so that it does not interfere with existing label searches, and so that tickets with label are always visible from relevant Project Board views.

### More Info
- Most likely this _only_ applies to the PM pre-work checklist, and not the weekly label check
- The weekly label check is concerned with "series: Missing", and covers a few edge cases where we allow missing labels to remain

### Action Items

- [ ] add new item to PM Recurring Agenda Items (see dropdown in References)
- e.g. "ensure all items in Questions/In-Review have ready-for-lead, ready-for-org-rep, or ready-for-peer-review"
- [ ] Add `-label:"ready for peer review"` to ["Missing Ready for labels"](https://github.com/orgs/hackforla/projects/63/views/22) project board view
- [ ] (optional) review [weekly label check](https://github.com/hackforla/311-data/issues/1134)
- [ ] confirm that there is no specific check that would apply to this label

### Resources/Instructions
- label: [ready for peer review](https://github.com/hackforla/311-data/issues?q=state%3Aopen%20label%3A%22ready%20for%20peer%20review%22)

Click to see PM Recurring Agenda Items

```md
### YYYY-MM-DD Recurring Agenda Items
- [ ] Update [311 Team Roster](https://docs.google.com/spreadsheets/d/1OsLDl7Ciwj7WjtzbgDz38g4kpOMNlUhdjlgzQxtQTvM/edit?gid=0#gid=0)
- [ ] Open views and check if any members need action, see: https://github.com/hackforla/311-data/issues/1494
- [ ] `check on website team member changes`
- [ ] `inactive remove from website`
- [ ] `Permissions to update-drive to viewer`
- [ ] `Permissions to update-remove write`
- [ ] Review all onboarding issues and see if any onboarding tracking comments are missing checkboxes
- [ ] https://github.com/hackforla/311-data/issues/1561
- [ ] https://github.com/hackforla/311-data/issues/1578
- [ ] https://github.com/hackforla/311-data/issues/1580
- [ ] https://github.com/hackforla/311-data/issues/1854
- [ ] Weekly Label Check: https://github.com/hackforla/311-data/issues/1134
- [ ] Review each issue in the [Project Board Icebox (temporary view)](https://github.com/orgs/hackforla/projects/63/views/1?filterQuery=status%3A%22Icebox+%28on+hold%29%22)
- [ ] Determine if the issue is still blocked. If unblocked, see if it's blocking ticket has a "Releases" section
- Q: should we make an issue for Icebox Review weekly audit?
- [ ] All issues in New Issue Review/Approval have either:
- [ ] The `ready for...` label: [Project Board: Missing Ready for Labels](https://github.com/orgs/hackforla/projects/63/views/22)
- If this link shows any issues in New Issue Approval, they need to be given the appropriate "ready for..." label
- [ ] The `draft` label and assignee
- [ ] All issues in Questions column have a `ready for...` label [Project Board: Missing Ready for Labels](https://github.com/orgs/hackforla/projects/63/views/22)
- If this link contains any issues in Questions, they need to be given the appropriate `ready for...` label.
- [ ] All issues in Review column have a `ready for...` label [Project Board: Missing Ready for Labels](https://github.com/orgs/hackforla/projects/63/views/22)
- If this link contains any issues in Review, they need to be given the appropriate `ready for...` label.
- [ ] Review the issues on [Project Board: Ready for Product](https://github.com/orgs/hackforla/projects/63/views/19)
- [ ] address them now or add to this agenda to discuss.
- [ ] For each issue in Questions that has `on agenda:` label, add a link to the question-asking comment from each new issue to the the agenda below
```


Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.