hackclub / hackclub/sprig

Thumbnail generation script causes games to crash, causing generation to fail

Open
#2,189 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
1.1k
Forks
1.8k
Avg merge
8d 12h
Merged PRs (30d)
12

Description

The thumbnail generation script overrides some functions with no-ops when running games. For example, setTune, for games running within the script, is set to `() => {}`. This causes some thumbnails to fail to generate, as seen below, when the return values of these functions are accessed (in this case: `playTune().end()`

Screenshot 2024-08-19 at 13 12 29

Relevant file: src/integrations/thumbnail.ts

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.