hackclub / hackclub/nephthys

Send-to-channel protection doesn't work

Open
#249 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
19
Forks
49
Avg merge
2d 21h
Merged PRs (30d)
6

Description

The bot used to un-send-to-channel messages like this (and the user would get an ephemeral msg explaining what's up)

Slack message in a thread that was also sent to channel

At some point this seemed to stop working? It used to very occasionally not work, but now it always doesn't work.

When fixing this, be sure to test the "send to channel" checkbox, and also sending to channel after the message has been sent. And add logs for when a message is un-sent-to-channel.

Contributor guide

Open the contributing guide

Research direction

Start by tracing the send-to-channel handling for both the checkbox path and sending to channel after the message has been posted. Reproduce both cases, verify the message is unsent and the user receives the ephemeral explanation, then add logs for each unsend event and tests covering both behaviors.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.