hackclub / hackclub/hcb

[StripeCardholder] Clean up Stripe update code paths

Open
#14,893 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
870
Forks
138
Avg merge
1d 14h
Merged PRs (30d)
208

Description

StripeCardholder data is updated in a couple ways. They potentially conflict or update Stripe twice.

- StripeCardholder before_validation
- This probably should be an after_save
- StripeCardholderService::Update
- UserController#update

Contributor guide

Open the contributing guide

Research direction

Start by reading the three named update paths: StripeCardholder#before_validation, StripeCardholderService::Update, and UserController#update. Trace how each updates Stripe and identify where their behavior conflicts or duplicates work. Done means the StripeCardholder update flow has one consistent path without conflicting or repeated Stripe updates.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend, payments
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.