hackclub / hackclub/hcb

[Payouts] Error with details in new payout method causes modal to close

Open
#14,749 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
870
Forks
138
Avg merge
1d 14h
Merged PRs (30d)
208

Description

### Describe your goals

Trying to add new payout method.

### Describe the bug

When there is an error (e.g. field blank) the entire modal closes and the error message is on the top-left. The incorrect draft details save but obviously the modal probably shouldn't close.

Contributor guide

Open the contributing guide

Research direction

No file, test, or entry point is identified in the issue. Start by reproducing the payout-method flow with a blank field and observe the modal and error placement; done means the modal remains open, the validation error is shown appropriately, and the invalid draft does not save incorrectly.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
payments
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.