[Settings] Change SMS preference setting to SMS auth availability
- Dominant language
- Ruby
- Stars
- 870
- Forks
- 138
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 208
Description
This toggle value isn't currently consumed anywhere in our codebase:
Our new authentication flow relies on the last successful login preference, not the "Prefer login codes via SMS" setting.
We should change this toggle to something along the lines of "Allow signing in with SMS login codes?", change the column to be enabled by default, add a check for this setting in `Login#available_factors` (make it reference a new `sms_available?` method), and write a backfill script to enable it for all users retroactively.
Contributor guide
Research direction
Start at Login#available_factors and trace the existing SMS preference setting and its column. Define the new sms_available? check, update the toggle label and default, then add a backfill that enables it for all users. Done means SMS availability follows the setting and existing users are enabled retroactively.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- authentication, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100