hackclub / hackclub/hcb

[Reimbursement] Reviewer without access edge case

Open
#13,403 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
870
Forks
138
Avg merge
1d 14h
Merged PRs (30d)
208

Description

I haven't tested this, but I think there may be an edge case:
- Bob creates a reimbursement report on DevHacks
- Bob assign Alice (a manager on DevHacks) as the reviewer for the report
- Bob move the report to ExpensiCon
- Alice does not have access to DevHacks and thus can't review

In this case, we should probably just clear the reviewer field, but pls first test to see whether this is a real bug or not

Contributor guide

Open the contributing guide

Research direction

Start by locating the reimbursement report code that assigns reviewers and checks organization access. Reproduce the DevHacks-to-ExpensiCon scenario described in the issue to confirm whether Alice can still review. Done means the behavior is confirmed or disproved and, if it is a bug, the reviewer is cleared with a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.