h4cc / h4cc/slugger

Breaking changes in 0.3

Open
#32 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
Elixir
Stars
160
Forks
26
PR merge metrics
No merged PRs in 30d

Description

It looks like there's some breaking changes in 0.3. I haven't looked into them too fully yet but some of my tests are now breaking. Here's an example `FunctionClauseError` I'm getting.

```
** (FunctionClauseError) no function clause matching in Regex.replace/4

The following arguments were given to Regex.replace/4:

# 1
~r/['’]s/u

# 2
nil

# 3
"s"

# 4
[global: nil]

Attempted function clauses (showing 2 out of 2):

def replace(regex, string, replacement, options) when is_binary(string) and is_binary(replacement) and is_list(options)
def replace(regex, string, replacement, options) when is_binary(string) and is_function(replacement) and is_list(options)

code: conn = post conn, api_community_path(conn, :create), %{community: community_params}
stacktrace:
(elixir) lib/regex.ex:595: Regex.replace/4
(slugger) lib/slugger.ex:40: Slugger.slugify/2
```

Is there any documentation of the breaking changes?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.